This is a static archive of our old Q&A Site. Please post any new questions and answers at ask.wireshark.org.

What kind of changes should I commit for review?

0

Hi, I'm working on Wireshark development for my company. We're trying to keep it as close to the official release as possible. So, we're only adding commits from dev-release as needed to keep it 1.12-like. We're also submitting some changes that we deem useful upstream for review into official release. My question is, what kind of changes should be submitted review? As an example, should we keep our own dictionaries of Vendor Specific diameter AVP codes, or should we submit it to the official version instead?

Thanks up front!

asked 11 Nov '15, 07:49

Aliniel's gravatar image

Aliniel
308915
accept rate: 100%


One Answer:

1

It should be ok to submit your vendor specific AVPs and any other changes you have made.

answered 11 Nov '15, 08:54

Anders's gravatar image

Anders ♦
4.6k952
accept rate: 17%

Any contribution should be made towards master.

(11 Nov '15, 08:55) Anders ♦