We are considering submitting a large set of code related to a set of protocols that is currently internal but will be opened over the next few months. The submission includes an entire protocol stack. I would like to talk to someone about the best/most efficient way to get the code submitted and reviewed. Who is the best contact? asked 03 Feb '15, 12:32  beastham |
One Answer:
There is the Developers Guide section on submitting changes that has lots of good advice on requirements, and the wiki page on the current procedure to submit using Gerrit. The changes will be reviewed on Gerrit and, if required, on the developers mailing list, but that's usually for more invasive changes rather than dissector additions. We would prefer the dissectors to be built in rather than plugins and also take note of the licensing requirements, for which see the FAQ. answered 03 Feb '15, 13:47  grahamb ♦ |
It might be a good idea to have one dissector per committ, to make reviewing it managble.
I have read all of the guides, so I'm looking for more specifics on the best/easiest way to move forward. Anders' comment is the kind of information I am looking for. To clarify, I am talking about ~11K lines of code, currently building as 16 separate plugins. I do not want to burden the core developers too much. I'll work on a plan for starting with the base dissectors and working from there.
We try to cut back on plugins as much as possible, therefore it's good practice to convert them to build-in dissectors before sending them. If coded properly this should be a simple as moving the dissector files to
epan/dissectors/while dropping most plugin helper files.My 2cents:
I would suggest submitting maybe one or two "base dissectors" for review as a start before going through the effort to submit all the dissectors.
That way you can get feedback on any overall issues (API usage,etc, etc) which might require changes in some/all of the rest of the dissectors.
Thanks to everyone. I will work on an initial submission and build from there. I do plan to convert from plugins before submitting.