SO here is what I did, I used the source code of another free software under(GPL license) in my wireshark development version and made some enhancements that were not there in wireshark. Now I want to contribute it to the source. Is this setting fine? Or DO I have to rewrite all the code that I used from the other software? Any insights? Thanks a lot! -Koundi asked 26 Aug '15, 23:51  koundi |
2 Answers:
As far as I know that is perfectly fine. I think it only may be a problem if the licenses differ. answered 27 Aug '15, 00:30  Anders ♦ Thanks Anders for the prompt response. Both the softwares(wireshark and the other software) are under general public license(GPL).Are there are any more pitfalls that I need to be careful about ? -koundi (27 Aug '15, 01:12) koundi Seems as though the licences are OK, now you need to think about all the platforms Wireshark runs on, e.g. Linux, OSX, Windows, Solaris and a few others. Does your other software run on the above platforms? (27 Aug '15, 01:53) grahamb ♦ I have checked on windows and Linux. But given that we have access to the source code, it wont be a problem as we can always include os specific headers. Right ? Thanks -Koundi (27 Aug '15, 04:02) koundi If you are linking to other libraries it might need discussion, if you are copying code it's more of a licencing question, I think. But you'd have to be more specific. One way is to upload your code yo gerrit and have it reviewed. (27 Aug '15, 05:03) Anders ♦
what is that other software? (28 Aug '15, 08:21) Kurt Knochner ♦ @kurt I have integrated this code into my development version (https://github.com/gteissier/srtp-decrypt). After making a bunch of changes adding some code of my own to create UI for keys, support multiple streams and handling some other issues. -koundi (31 Aug '15, 00:12) koundi showing 5 of 6 show 1 more comments |
Great! Please follow the steps at https://www.wireshark.org/develop.html to submit your patch. Make sure you include the Copyright and author messages of the project(s) your code is using. answered 31 Aug '15, 11:48  jmayer |
GPL, as in GPL2, GPL2+, or GPL3? Unfortunately it does matter. See this answer on compatibility.
@Jaap I dont think that is a problem looks like both are under GPL version 2 license!From what I read wireshark is under GPL 2 license right?