1.6.1 Display filter Expression Dialog Box Error and solution :-)

Question

Hello there,

I'm glad to say that I 've come up with a small contribution to Wireshark. Display Filter dialog box is created each time whenever the Expression button in the filter tool bar is pressed. Likewise it can create n times for n clicks.

Accepted Answer

//global section

static GtkWidget *window= NULL;

..........

GtkWidget *

dfilter_expr_dlg_new(GtkWidget *filter_te) { if (window != NULL) {

    /* There's already an "Expression" dialog box; reactivate it. */
    reactivate_window(window);
    return window;
}
else
{ 
       //keep the code that is present inside dfilter_expr_dlg_new function in this else part
    }
}

Answer 2

The way to contribute code to wireshark is to create a "bug"-report on https://bugs.wireshark.org/ and attach the output of "svn diff". This way we don't lose track of all submissions.